[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

[WordPress Trac]

#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  Iceable
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  accessibility,
  patch dev-feedback has-            |  javascript
  screenshots 2nd-opinion has-ux-    |
  feedback                           |
-------------------------------------+-------------------------------------

Comment (by birgire):

 Tested [attachment:"48222-5.diff"] and it seems to work well on my
 install.

 Noticed few things though:

 In Chrome (Win10) the ''reset password'' screen looks like:

 [[Image(https://i.imgur.com/PRemO1u.jpg)]]

 where the eye-icon is pushed down.

 It seems to come from {{{height: 100%}}} of {{{.login .button.button-
 secondary}}}.


 Also just for reference, the ''login screen'' with LastPass (password
 manager) enabled:

 [[Image(https://i.imgur.com/kn3sqsH.jpg)]]

 Noticed an empty {{{style}}} attribute in [attachment:"48222-5.diff"]:

 {{{
 <div class="wp-hide-pw-wrap hide-if-no-js" style="
 ">

 }}}

 ps: the patch contains some HTML changes like:

 - changes some p tags to div tags.
 - removes some br tags.
 - adjusts the scope of some label tags.

 Out of curiosity, are these necessary for the ticket?

 Just wondering if it could affect those that have made CSS adjustments to
 their login screen?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform