[wp-trac] [WordPress Trac] #41305: Add lazily evaluated translations
WordPress Trac
noreply at wordpress.org
Mon Apr 30 07:52:56 UTC 2018
#41305: Add lazily evaluated translations
------------------------------------------+--------------------------------
Reporter: schlessera | Owner: jnylen0
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.0
Component: I18N | Version: 4.8
Severity: normal | Resolution:
Keywords: has-patch early dev-feedback | Focuses: rest-api,
| performance
------------------------------------------+--------------------------------
Comment (by swissspidy):
> They are all part of the `Tests_L10n_loadTextdomainJustInTime` suite,
and I'm not sure they need fixing. If I understand correctly what they are
testing, I think the tests should just be adapted to move the
`remove_filter()` calls after the `assert()` instead of in front of it.
The statements are ordered that way so everything gets cleaned up
immediately when not being used anymore (e.g. in case of errors) and
assertions are nicely grouped together to make things easier to grasp.
Shouldn't be a big deal to re-order those.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41305#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list