[wp-trac] [WordPress Trac] #43715: Add Privacy Policy link to bundled theme footers

[WordPress Trac]

#43715: Add Privacy Policy link to bundled theme footers
-------------------------------------------------+-------------------------
 Reporter:  xkon                                 |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9.6
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  gdpr has-patch needs-testing needs-  |     Focuses:  ui
  dev-note                                       |
-------------------------------------------------+-------------------------

Comment (by iandunn):

 I tested [attachment:43715.7.diff] on some WordCamp sites, to get some
 real-world data. WordCamp.org doesn't allow customizing the markup,
 though, only the CSS, so this wouldn't reveal any issues related to
 modified markup in child themes.

 Of the `89` sites I checked, `27` had some kind of problem (`30%`). My
 initial feeling is that none of them are blockers, but it'd be really nice
 if we can find a way to mitigate the worst of them.

 == Common Problems ==

 1. By far the most common root problem was custom CSS targeting `.site-
 info a`. Previously the `proudly powered...` link was the only thing
 there, so this didn't have any side-effects. With the privacy link and
 `span`, though, it causes various issues.
   [[br]][[br]]
   We could possible move the privacy link outside of `site-info`, but that
 might be worse semantically, and would probably cause some other issues,
 although they might be less bad.
   [[br]][[br]]
   Regardless, it might be helpful to add a `class` to the `proudly-
 powered` links for all themes, so that it can be targeted specifically,
 rather than relying on `.site-info a`.
   [[br]][[br]]
 1. The second most common problem was that the `.site-info
 span[role="separator"]::before` rules weren't applied on some sites, so
 the `/` was missing and the `span` had a `width` of `0`. This is an odd
 one, and I haven't determined the cause yet. It's not that the rules were
 applied, and then overwritten by something else, they just don't exist in
 the DOM inspector. I'll need to dig into it some more.
   [[br]][[br]]
 1. The third common problem was that `#colophon` had a dark background
 color set with custom CSS, and TwentyThirteen's default text color is also
 dark. A corresponding `color` wasn't set, because previously only links
 were inside the element, which have their own `color` properties. I don't
 have any ideas on improving the situation here.

 ----

 == Details ==

 I've linked to the sites below for reference, but the problems don't show
 up on production right now, since WordCamp.org is running the `4.9`
 branch. To reproduce, you'll need to manually insert the markup & CSS with
 dev tools, or wait until `4.9.6-beta1` is tested and deployed to
 production (assuming there aren't any bugs that prevent that).

 === TwentyEleven ===

 Tested `9` sites, no issues found.

 === TwentyTwelve ===

 Tested `20` sites,

 *  Separator misaligned, and no space between "privacy policy" and
 "proudly powered", because custom CSS has `.site-info a { float: left; }`
  * https://2018.birmingham.wordcamp.org/,
  * https://2017.bratislava.wordcamp.org/,
  * https://2016.bratislava.wordcamp.org/
  * https://2016.marbella.wordcamp.org/,
  * https://2016.belohorizonte.wordcamp.org/
  * https://2016.minneapolis.wordcamp.org/
  * https://2016.dfw.wordcamp.org/
  * https://2016.seattle.wordcamp.org/
  * https://2016.nashik.wordcamp.org/
  * https://2015.buenosaires.wordcamp.org/

 * Link doesn't show up because site is using Jetpack's "infinite footer",
 which sets `#colophon` to `display: none`, and creates a new footer
 element that doesn't include the link. Reported in
 [https://github.com/Automattic/jetpack/issues/9435 9345-jetpack]
  * https://2017.bordeaux.wordcamp.org/

 * Separator not easily visible because `#colophon` has a dark background
 color and TwentyTwelve's default text color is also dark.
  * https://2016.miami.wordcamp.org/
  * https://2016.denpasar.wordcamp.org/


 === TwentyThirteen ===

 Tested `20` sites.

 * Separator not easily seen b/c `#colophon` has a dark background color
 and TwentyThirteen's default text color is also dark.
  * https://2018.oc.wordcamp.org/
  * https://2016.chicago.wordcamp.org/
  * https://2016.birmingham.wordcamp.org/

 * Separator not visible because `::before { content }` is missing, even
 though not overridden by other CSS.
  * https://2017.asheville.wordcamp.org/

 * Links intentionally hidden with `.site-footer .site-info a { display:
 none; }`, but separator still shown.
  * https://2017.london.wordcamp.org/

 * Jetpack infinite footer
  * https://2016.asheville.wordcamp.org/

 * `proudly powered` replaced by WP logo, but logo applied to privacy link
 too, because targeted with `.site-info a`
  * https://2016.london.wordcamp.org/

 * Separator misaligned because setting `display: block` on `.site-footer
 a`
  * https://2016.wilmington.wordcamp.org/


 === TwentyFourteen ===

 Tested `10` sites

 * Separator not visible because `::before { content }` is missing
  * https://2017.marseille.wordcamp.org/
  * https://2016.paris.wordcamp.org/


 === TwentyFifteen ===

 Tested `10` sites

 * `proudly powered` replaced by WP logo, but affects both links because
 targeted `.site-info a`
  * https://2018.lancasterpa.wordcamp.org/


 === TwentySixteen ===

 Tested `10` sites

 * Separator looks out of place because `site-title` was hidden
  * https://2017.halifax.wordcamp.org/

 * Separator not visible because `::before { content }` is missing, similar
 to `2017.asheville`
  * https://2017.dc.wordcamp.org/


 === TwentySeventeen ===

 Tested `10` sites.

 * Separator not visible because `::before { content }` is missing, similar
 to `2017.asheville`
  * https://2018.rotterdam.wordcamp.org/

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43715#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform