[wp-trac] [WordPress Trac] #43715: Add Privacy Policy link to bundled theme footers

WordPress Trac noreply at wordpress.org
Wed Apr 25 19:43:55 UTC 2018


#43715: Add Privacy Policy link to bundled theme footers
-------------------------------------------------+-------------------------
 Reporter:  xkon                                 |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9.6
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  gdpr has-patch needs-testing needs-  |     Focuses:  ui
  dev-note                                       |
-------------------------------------------------+-------------------------
Changes (by iandunn):

 * keywords:  gdpr has-patch needs-testing => gdpr has-patch needs-testing
     needs-dev-note


Comment:

 Awesome :)

 It looks like for all of the themes, the separator psuedo-element is added
 ''after'' the link text, except for TwentyTen, where it's ''before''. I'm
 assuming that was intentional, but just wanted to double check.

 @xkon, can you add a link to the discussion you had with `#themereview`? I
 couldn't find it, but I think it may be helpful.

 ----

 @laurelfulford, @davidakennedy: do you have time to give some feedback
 about the impact this will have on child themes that are based on the
 bundled themes?

 The new link markup won't be added default, because the link isn't added
 unless the user has created and set a Privacy Policy (#43435). The styles
 will still apply, though, and could conflict with some child theme
 elements/styles.

 And then once the user creates the privacy page, the additional markup
 will be added, which may also cause some conflicts.

 Once any issues there are mitigated, we should probably post a dev note on
 make/Core to let theme authors know they should check for how this impacts
 their child themes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43715#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list