[wp-trac] [WordPress Trac] #43850: Add privacy policy URL template tags

[WordPress Trac]

#43850: Add privacy policy URL template tags
------------------------------------------+--------------------------------
 Reporter:  iandunn                       |       Owner:  iandunn
     Type:  enhancement                   |      Status:  assigned
 Priority:  normal                        |   Milestone:  4.9.6
Component:  General                       |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr needs-testing has-patch  |     Focuses:  ui,
                                          |  administration
------------------------------------------+--------------------------------

Comment (by birgire):

 @iandunn Thanks for the merge, that looks good

 Here are few suggestions:

 - Change {{{Tests_Link_GetPrivacyPolicyUrl()}}} to
 {{{Tests_Url_GetPrivacyPolicyUrl()}}}.

 - The tag {{{@subpackage}}} seems to be on it's way out in the future
 according to the Handbook [https://make.wordpress.org/core/handbook/best-
 practices/inline-documentation-standards/php/#deprecated-tags here].

 - The cleanup must come before assertions, else the cleanup might not run
 on a failure.
  We should remove the filter callbacks before the assertion.

 - Add a parameter comment here:
 {{{
 * @param WP_UnitTest_Factory $factory
 }}}

 - Add member variable doc comments here:

 {{{
 protected static $privacy_policy_page_id;
 protected static $privacy_policy_url;
 protected static $before;
 protected static $after;

 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43850#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform