[wp-trac] [WordPress Trac] #43850: Add privacy policy URL template tags
WordPress Trac
noreply at wordpress.org
Wed Apr 25 00:20:48 UTC 2018
#43850: Add privacy policy URL template tags
------------------------------------------+--------------------------------
Reporter: iandunn | Owner: iandunn
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.9.6
Component: General | Version: trunk
Severity: normal | Resolution:
Keywords: gdpr needs-testing has-patch | Focuses: ui,
| administration
------------------------------------------+--------------------------------
Comment (by iandunn):
[attachment:43850.2.diff] merges the tests from
[https://core.trac.wordpress.org/attachment/ticket/43620/43620.policy_url.policy_link_4.diff
43620.policy_url.policy_link_4.diff] and [attachment:43850.diff].
@birgire, can you take a look and let me know what you think?
Based on the [https://make.wordpress.org/core/handbook/testing/automated-
testing/writing-phpunit-tests/#naming-and-organization the docs], it
sounds like `tests/link/getThePrivacyPolicyLink.php` and
`tests/url/getThePrivacyUrl.php` are the best places for these.
`test/url/` didn't exist previously, so I created it. There are a lot of
tests in `tests/url.php`, but it seems like they're an artifact from
before the guideline was to create separate files for each function being
tested.
I still need to go over the patch with fresh eyes tomorrow, but I think
it's in pretty good shape. @azaozz, do you mind giving the tests a quick
glance, in case I missed anything? The functions in `link-template.php`
haven't been changed, so they should still be good to go.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43850#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list