[wp-trac] [WordPress Trac] #43715: Add Privacy Policy link to bundled theme footers

[WordPress Trac]

#43715: Add Privacy Policy link to bundled theme footers
-------------------------+-----------------------
 Reporter:  xkon         |       Owner:  xkon
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  4.9.6
Component:  General      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  gdpr         |     Focuses:  ui
-------------------------+-----------------------

Comment (by xkon):

 @iandunn Everything moved into
 https://core.trac.wordpress.org/ticket/43620#comment:35 just informing so
 we won't go back and forth in tickets and get lost again.

 I'll reply here though for these points as they are theme related mostly.

 I tried to be as consistent as possible with whatever code exists in
 themes already so :

 **<span>**: If we ad a divider with a:after it goes within the `<a>` tag
 so it will inherit all on :hover and other styles of the `a` as well and
 that means even more CSS styles to make it visually independent from the
 link without a good reason, so I thought of following the same way it's
 already done in Twenty Sixteen's footer that adds a divider with `.site-
 title:after`

 {{{
 <span class="site-title"><a href="http://develop.oo/src/" rel="home">My
 Website</a></span>
 }}}

 This way if you ad a divider with :after, it doesn't get highlighted as
 well as it's out of the <a> and the themes handle it as plain text for
 visual purposes if that makes sense now.

 **::after / :after** /: Again I just went with whatever I saw in the .css
 files already being done.

 As for the `aria-label` I think you're correct, I'm not that well versed
 with accessibility and I'm always getting confused, I thought the more
 labels the better (for some reason). But I wasn't 100% sure. We can update
 the .diff in the other ticket with whatever is needed for this :) .

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43715#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform