[wp-trac] [WordPress Trac] #43715: Add Privacy Policy link to bundled theme footers

[WordPress Trac]

#43715: Add Privacy Policy link to bundled theme footers
-------------------------+-----------------------
 Reporter:  xkon         |       Owner:  xkon
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  4.9.6
Component:  General      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  gdpr         |     Focuses:  ui
-------------------------+-----------------------

Comment (by iandunn):

 Replying to [comment:28 xkon]:
 > In [attachment:43715.3.diff] fixed the CS errors and added the
 appropriate CSS in all themes.

 I think that's looking good :)

 I'd keep `?>` on the same line as the `<?php if()`, to make it cleaner to
 read, and consistent with other places in Core.

 Should we use `::before` instead of `:before`? I think the latter is CSS2
 syntax, and all the browsers we support can handle the CSS3 syntax.

 > @iandunn I'm using a `<span>` as a wrapper for the link so I can place
 the dividers `/` where necessary by doing `:after` or `:before` in css.
 This way users can easily change it to something else or hide it etc. Imho
 it's a bit more accessible this way just in case. It's the same principle
 as used in TwentySixteen by design.

 Huh, I'm not sure I understand. I tested out adding adding the dividers on
 the `a` instead of the `span`, and some styles like `text-decoration` need
 the psuedo element to be `display: inline-block`, but other than that it
 worked fine.

 What specific problem are you running in to?


 > @birgire I replace the `title` with `aria-label` instead. I think we're
 ok with this correct? :)

 Is that necessary in this context? I thought that that was used in
 [https://developer.mozilla.org/en-
 US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-
 label_attribute cases where the anchor text was not descriptive], for
 example:

 `<button aria-label="Close" onclick="myDialog.close()">X</button>`

 It seems like in this case, the anchor text might be all that's needed?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43715#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform