[wp-trac] [WordPress Trac] #43328: Add support for Web App Manifests
WordPress Trac
noreply at wordpress.org
Wed Apr 11 14:38:39 UTC 2018
#43328: Add support for Web App Manifests
-----------------------------+-----------------------------
Reporter: westonruter | Owner: westonruter
Type: feature request | Status: accepted
Priority: normal | Milestone: Future Release
Component: General | Version:
Severity: normal | Resolution:
Keywords: | Focuses: javascript
-----------------------------+-----------------------------
Comment (by westonruter):
In the Jetpack defaults
[https://github.com/Automattic/jetpack/blob/12648fad888d48e2647b1a2aa07e756035e6f2ee/modules/pwa/class
.jetpack-pwa-manifest.php#L61 there is]:
{{{
'short_name' => substr( get_bloginfo( 'name' ), 0, 12 ),
}}}
Where was the length of 12 determined? Truncating it like that could
produce undesirable results. At least an ellipsis should be added, but
otherwise maybe it would be better to default to the domain name (if not a
subdirectory multisite install).
I think the `name` and `shortname` is also missing a good default configs
for `lang` and `dir` which we can provide automatically.
Also, for `display` perhaps the default of `browser` is better than
`standalone`? Just thinking that if this is rolled out across all
WordPress installs does it make sense for every WordPress site I add to my
homescreen to be a different standalone app by default? I think that
should maybe be opt-in via filter.
I think including `scope` in addition to `start_url ` may be worthwhile.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43328#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list