[wp-trac] [WordPress Trac] #43436: Add opt-in for commenter cookies

WordPress Trac noreply at wordpress.org
Wed Apr 4 14:13:41 UTC 2018


#43436: Add opt-in for commenter cookies
----------------------------------------+------------------
 Reporter:  azaozz                      |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  5.0
Component:  Bundled Theme               |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  gdpr has-patch 2nd-opinion  |     Focuses:
----------------------------------------+------------------
Changes (by azaozz):

 * keywords:  gdpr has-patch needs-testing => gdpr has-patch 2nd-opinion
 * component:  Comments => Bundled Theme


Comment:

 @xkon thanks for the patch! Looks good.

 The last thing I'm thinking about is if we should add an inline style
 `display: inline;` for the `<label>`.

 I know, --everybody-- hates inline styles, but really don't see good way
 to fix this for all themes.

 Alternatively can output a `<style>` tag in the head with something like:
 {{{
 #commentform .comment-form-cookies-consent label[for="wp-comment-cookies-
 consent"] {
     display: inline;
 }
 }}}

 Which is the "lesser evil"? :)

 Moving this to the "Bundled Themes" component as it mostly concerns the
 theme.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43436#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list