[wp-trac] [WordPress Trac] #41986: Use regular core button styling for page header buttons

[WordPress Trac]

#41986: Use regular core button styling for page header buttons
-----------------------------------------------+---------------------------
 Reporter:  melchoyce                          |       Owner:
     Type:  enhancement                        |      Status:  new
 Priority:  normal                             |   Milestone:  Awaiting
Component:  General                            |  Review
 Severity:  normal                             |     Version:
 Keywords:  ui-feedback 2nd-opinion has-patch  |  Resolution:
                                               |     Focuses:  ui,
                                               |  administration
-----------------------------------------------+---------------------------

Comment (by danieltj):

 Replying to [comment:5 helen]:
 > Some thoughts:
 >
 > 1. We've tried for a long time to adhere to buttons only being used for
 form submission or in-page actions, but I'm not sure just how successful
 we've actually been or if this is something that still matters today.
 > 2. The current styling for that link already looks so much like a button
 that it rather looks like something is wrong with it as opposed to
 purposefully being not-a-button.
 > 3. There are instances where it '''is''' an in-page action - see
 uploading a theme.
 > 4. In core usage I would disagree that it's '''the''' primary action on
 any page so it shouldn't be blue. The blue outline is the standard focus
 styling, color is not related to primary-ness.
 > 5. We should be aware of what plugins are doing with that class and
 adding links to that area, it may (or may not) affect the actual code
 change decision (changing classes vs. changing CSS for the existing
 class).

 Many plugins are using the page-title-action class to place buttons there
 next to the h1 on the page, so we can't remove that without breaking the
 layout of plugins who are using it (''two of my plugins do, I've also seen
 many others'').

 Additionally, that button has always been for single core actions within
 the admin dashboard. On each page that has one it's almost always used to
 add something new so I disagree, it is the primary focus (not all the
 time, but most of the time).

 My opinion is that it should be left as is, or changed to use the primary
 button class to make it more blue so it stands out. Changing it to have
 the secondary class so it's fully grey will make the button just as much,
 if not less noticeable than it already is.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41986#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform