[wp-trac] [WordPress Trac] #41986: Use regular core button styling for page header buttons

WordPress Trac noreply at wordpress.org
Tue Sep 26 02:08:31 UTC 2017


#41986: Use regular core button styling for page header buttons
-----------------------------------------------+---------------------------
 Reporter:  melchoyce                          |       Owner:
     Type:  enhancement                        |      Status:  new
 Priority:  normal                             |   Milestone:  Awaiting
Component:  General                            |  Review
 Severity:  normal                             |     Version:
 Keywords:  ui-feedback 2nd-opinion has-patch  |  Resolution:
                                               |     Focuses:  ui,
                                               |  administration
-----------------------------------------------+---------------------------

Comment (by helen):

 Some thoughts:

 1. We've tried for a long time to adhere to buttons only being used for
 form submission or in-page actions, but I'm not sure just how successful
 we've actually been or if this is something that still matters today.
 2. The current styling for that link already looks so much like a button
 that it rather looks like something is wrong with it as opposed to
 purposefully being not-a-button.
 3. There are instances where it '''is''' an in-page action - see uploading
 a theme.
 4. In core usage I would disagree that it's '''the''' primary action on
 any page so it shouldn't be blue. The blue outline is the standard focus
 styling, color is not related to primary-ness.
 5. We should be aware of what plugins are doing with that class and adding
 links to that area, it may (or may not) affect the actual code change
 decision (changing classes vs. changing CSS for the existing class).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41986#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list