[wp-trac] [WordPress Trac] #42373: Customizer: Can't Schedule 0:00 - 0:59 when 24-hour clock setting

WordPress Trac noreply at wordpress.org
Mon Oct 30 05:42:13 UTC 2017


#42373: Customizer: Can't Schedule 0:00 - 0:59 when 24-hour clock setting
--------------------------+--------------------------
 Reporter:  atachibana    |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------------

Comment (by westonruter):

 I found some additional issues with date time control.

 * Min/max could be simplified, as @peterwilsoncc patched in
 [attachment:42373.3.diff].
 * Setting validity message was not properly translatable.
 * Emptying an input or giving it an invalid value would not trigger an
 error to keep the customizer from saving (silently accepted).
 * Zero-padding was getting in the way of user input.

 I don't really see the need for `updateMinutesForHour`. The `max` for
 minutes can be just always 59. I don't think we need to worry about
 supporting `24:00`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42373#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list