[wp-trac] [WordPress Trac] #41083: IP with port number triggers warnings in WP_Community_Events

[WordPress Trac]

#41083: IP with port number triggers warnings in WP_Community_Events
--------------------------------------+-----------------------------
 Reporter:  EatonZ                    |       Owner:  iandunn
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.9
Component:  Administration            |     Version:  4.8
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  administration
--------------------------------------+-----------------------------
Changes (by pento):

 * keywords:  good-first-bug has-patch 2nd-opinion => has-patch has-unit-
               tests


Comment:

 [attachment:41083.diff] adds support for IPv6 compatibility mode, and a
 bunch more tests. I also moved everything back into the single method,
 because all this code is really only being used in this one place.

 Unfortunately, any code dealing with IP addresses is going to be
 inherently inelegant, as IP addresses are a messy problem. Handling all
 the weird edge cases makes everyone sad.

 Unless anyone wants to iterate on this a bit more, I'm fine with
 committing it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41083#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform