[wp-trac] [WordPress Trac] #42102: File Editor: Make fatal error detection more robust for edits to PHP files

[WordPress Trac]

#42102: File Editor: Make fatal error detection more robust for edits to PHP files
--------------------------------------------+--------------------------
 Reporter:  westonruter                     |       Owner:  westonruter
     Type:  defect (bug)                    |      Status:  closed
 Priority:  normal                          |   Milestone:  4.9
Component:  General                         |     Version:
 Severity:  normal                          |  Resolution:  fixed
 Keywords:  has-patch needs-testing commit  |     Focuses:
--------------------------------------------+--------------------------
Changes (by westonruter):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"41805"]:
 {{{
 #!CommitTicketReference repository="" revision="41805"
 File Editor: Increase robustness of fatal error checking when saving PHP
 file edits.

 * Increase PHP execution time limit prior to issuing loopback requests
 where are themselves given timeouts to ensure PHP file can be reverted.
 * Output scrape messages on success and failure so that absence of either
 can also be flagged as an error condition.
 * Forward browser's HTTP Basic Auth credentials in loopback requests to
 admin and home URL.
 * Display more helpful message when loopback request fails.

 Amends [41721].
 See #21622.
 Fixes #42102.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42102#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform