[wp-trac] [WordPress Trac] #41526: Remove usage of each() from Text_Diff_Engine_native

[WordPress Trac]

#41526: Remove usage of each() from Text_Diff_Engine_native
------------------------------------------+--------------------------
 Reporter:  johnbillion                   |       Owner:  johnbillion
     Type:  task (blessed)                |      Status:  reopened
 Priority:  normal                        |   Milestone:  4.9
Component:  External Libraries            |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  needs-unit-tests needs-patch  |     Focuses:
------------------------------------------+--------------------------
Changes (by ocean90):

 * keywords:  needs-unit-tests has-patch => needs-unit-tests needs-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Since [41633] I'm seeing a few warnings like

 {{{
 Warning: assert(): assert($y <= $this->seq[$k]) failed in wp-
 includes/Text/Diff/Engine/native.php on line 199

 Warning: assert(): assert($ypos != $this->seq[$end]) failed in wp-
 includes/Text/Diff/Engine/native.php on line 239
 }}}


 I'm attaching rev1.txt and rev2.txt.

 * Create a new post with rev1.txt
 * Update content of the post with rev2.txt.
 * Go to the revisions screen where you should notice the warnings. I also
 got them once during updating the post.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41526#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform