[wp-trac] [WordPress Trac] #42022: Customize: Fix date time control defects

[WordPress Trac]

#42022: Customize: Fix date time control defects
--------------------------+--------------------------
 Reporter:  melchoyce     |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui
--------------------------+--------------------------

Comment (by westonruter):

 Replying to [comment:16 afercia]:
 > @westonruter noticed `add_control( new WP_Customize_Date_Time_Control
 ...` doesn't pass a label to the template, any reason to keep it in the
 template? Maybe in case it gets reused/extended?

 Yes, that is why it should be kept. See this example plugin which can then
 make use of it:
 https://gist.github.com/westonruter/ca1a77f9309af4ab258573cee5ed9d30

 > The labels for
 > custom_logo-button
 > site_icon-button
 > header_image-button
 > background_image-button
 >
 > are still not correct, maybe this should be handled in #33085 ?

 Yes, let's handle them there. That's the more appropriate place.

 > Lastly: on IE 11 and Edge, some fields need a slightly bigger width
 (different system font, takes more space). Maybe should be tested also on
 Linux? (at least one distro?)
 >
 > [[Image(https://cldup.com/IlQRS41c6K.png)]]

 Good catch. I think the problem here is also that these `select` dropdowns
 should have an `auto` width and not a fixed width, as they can be
 translated after all. I've fixed that in [https://github.com/xwp
 /wordpress-develop/pull/266/commits/3bd6bf3 3bd6bf3]. Look good?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42022#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform