[wp-trac] [WordPress Trac] #42022: Customize: Fix date time control defects

WordPress Trac noreply at wordpress.org
Sun Oct 1 14:34:44 UTC 2017


#42022: Customize: Fix date time control defects
--------------------------+--------------------------
 Reporter:  melchoyce     |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui
--------------------------+--------------------------

Comment (by afercia):

 @westonruter noticed `add_control( new WP_Customize_Date_Time_Control ...`
 doesn't pass a label to the template, any reason to keep it in the
 template?

 {{{
 <span class="customize-control-title">
         {{ data.label }}
 </span>
 }}}

 Maybe in case it gets reused/extended?

 The labels for
 custom_logo-button
 site_icon-button
 header_image-button
 background_image-button

 are still not correct, maybe this should be handled in #33085 ?

 Lastly: on IE 11 and Edge, some fields need a slightly bigger width
 (different system font, takes more space). Maybe should be tested also on
 Linux? (at least one distro?)

 [[Image(https://cldup.com/IlQRS41c6K.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42022#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list