[wp-trac] [WordPress Trac] #41905: Only loop over enclosure meta keys in rss_enclosure() and atom_enclosure()
WordPress Trac
noreply at wordpress.org
Sun Nov 12 17:38:55 UTC 2017
#41905: Only loop over enclosure meta keys in rss_enclosure() and atom_enclosure()
--------------------------------------+------------------------------
Reporter: birgire | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Feeds | Version: 2.2
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------------
Comment (by nateinaction):
@birgire Thanks for the feedback!
This updated diff fixes the whitespace issues which conflicted with WP
code standards. I have also fixed the data provider driven tests to align
with with your suggestion:
> I think it would be ideal if we could test both single and multiple
enclosures, with the data providers.
And all tests pass:
{{{
phpunit --group=feed
OK (18 tests, 268 assertions)
}}}
Please let me know what you think!
[attachment:41905.6.patch]
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41905#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list