[wp-trac] [WordPress Trac] #41905: Only loop over enclosure meta keys in rss_enclosure() and atom_enclosure()

WordPress Trac noreply at wordpress.org
Fri Nov 10 11:00:06 UTC 2017


#41905: Only loop over enclosure meta keys in rss_enclosure() and atom_enclosure()
--------------------------------------+------------------------------
 Reporter:  birgire                   |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Feeds                     |     Version:  2.2
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------

Comment (by birgire):

 @nateinaction you're surely welcome to join in and thanks for the patches.

 I'm a fan of data providers, but the test in [attachment:41905.3.diff]
 was adding multiple enclosures to a single post. The current data
 providers add a single enclosure. But I think it would be ideal if we
 could test both single and multiple enclosures, with the data providers.

 The reason I added the cleanup before the assertion is from here:

 https://core.trac.wordpress.org/ticket/42044#comment:1

 We should also make sure to satisfy the WordPress code standard, I use the
 phpcs to check for that:

 https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41905#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list