[wp-trac] [WordPress Trac] #41905: Only loop over enclosure meta keys in rss_enclosure() and atom_enclosure()

[WordPress Trac]

#41905: Only loop over enclosure meta keys in rss_enclosure() and atom_enclosure()
--------------------------------------+------------------------------
 Reporter:  birgire                   |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Feeds                     |     Version:  2.2
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------
Changes (by birgire):

 * keywords:  has-patch needs-refresh needs-unit-tests => has-patch has-
     unit-tests


Comment:

 Thanks for the feedback @stevenkword

 In [attachment:41905.3.diff] I added

  - a test for {{{rss_enclosure()}}} in {{{feed/rss2.php}}}
  - and another one for {{{atom_enclosure()}}} under {{{feed/atom.php}}}.

 I agree, it's sounds better to split it up, even though there's some
 duplication there.

 All tests in {{{rss2.php}}} seems to run successfully:

 {{{
 OK (12 tests, 170 assertions)
 }}}

 and same for {{{atom.php}}}:

 {{{
 OK (3 tests, 95 assertions)
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41905#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform