[wp-trac] [WordPress Trac] #41905: Only loop over enclosure meta keys in rss_enclosure() and atom_enclosure()

WordPress Trac noreply at wordpress.org
Thu Nov 9 21:17:32 UTC 2017


#41905: Only loop over enclosure meta keys in rss_enclosure() and atom_enclosure()
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Feeds                                |  Review
 Severity:  normal                               |     Version:  2.2
 Keywords:  has-patch needs-refresh needs-unit-  |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------
Changes (by stevenkword):

 * keywords:  has-patch has-unit-tests => has-patch needs-refresh needs-
     unit-tests


Comment:

 Patch still applies cleanly to 4.9 RC2 at revision 42138.  However, the
 unit test, "Tests_Feeds_Atom::test_atom_and_rss_enclosures" fails.  I
 would also recommend splitting the RSS and Atom unit tests apart.  There
 are two different files located in "tests/feed" for each feed type
 respectively.  There may be some redundancy in these tests, but it is
 better to split them apart.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41905#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list