[wp-trac] [WordPress Trac] #40771: Unable to add YouTube video to Video Widget

WordPress Trac noreply at wordpress.org
Tue May 16 16:39:27 UTC 2017


#40771: Unable to add YouTube video to Video Widget
--------------------------+--------------------
 Reporter:  taijacg       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.8
Component:  Widgets       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------

Comment (by westonruter):

 I see `get_rest_url()` is only looking at `is_ssl()` for whether to use
 the HTTPS protocol. When there is a proxy in front, it often returns the
 incorrect value as has been discussed in the context of #31288. I think
 the best solution is to just strip off the protocol. @taijacg do you have
 HTTPS termination on a reverse proxy?

 In regards to [attachment:40771-1.diff], I think we should use
 `jQuery.trim()` instead of `String.prototype.trim()`, as the latter is
 only available in IE11. True we're not supporting older IE anymore, but no
 need to break for such a trivial thing.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40771#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list