[wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query

[WordPress Trac]

#33885: meta_form performs a potentially expensive query
-------------------------------------+-----------------------------
 Reporter:  jorbin                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Administration           |     Version:  4.3.1
 Severity:  critical                 |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  performance
-------------------------------------+-----------------------------

Comment (by johnjamesjacoby):

 Hey @robscott, thanks for the reply. I’ll cover my concern quickly here,
 and I’m happy to chat more with anyone more outside of this ticket (don’t
 want to pollute anyone’s inboxes, and don’t want to leave you hanging
 either.)

 My concerns with one-off database alters are:

 * Future attempts to alter may fail without warning, and nobody will
 remember why that might be
 * Database alters aren’t in version control, so there is no history or log
 of that event having occurred to refer back to
 * One table performs differently than the others, using the same
 procedural API on top of it, again, without an obvious reason why to other
 people who work on the site
 * Reverting this change later (once WordPress itself is improved) may not
 be desirable, or forgotten completely

 TL;DR - It’s confusing for other people if something else goes wrong.
 Improve without compromising future improvements.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform