[wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query

[WordPress Trac]

#33885: meta_form performs a potentially expensive query
-------------------------------------+-----------------------------
 Reporter:  jorbin                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Administration           |     Version:  4.3.1
 Severity:  critical                 |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  performance
-------------------------------------+-----------------------------

Comment (by robscott):

 @johnjamesjacoby nice points, well made :)

 However, your caution aside, in reality, sites (like the
 `wp_is_large_site()` woocommerce sites (great idea btw) you mention) which
 exhibit this issue are managed by people who are seeing 8 second load
 times every time they do some action in admin of their site. This is not
 okay for such users, who may go to some other software because of it...

 Now, as WooCommerce is moving towards using "other places" to store data,
 in addition to the other forthcoming updates, I suspect this issue will
 wash through in time. BUT, where this is a problem, right now, it is a big
 one, which can drive site admin pretty crazy!

 The solution, while a bandaid, to perform some optimizations on the
 database, does work, today, to make admin faster.

 That solution being `ALTER TABLE wp_postmeta MODIFY meta_key
 varchar(191);`

 "It's a change you will quickly forget you made here, and will inevitably
 cause a problem years from now in your application."

 What, specifically, are the inevitable problems here? (assuming I don't
 forget changes made to the db!)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform