[wp-trac] [WordPress Trac] #39055: REST API: order is ignored when orderby is set to include

WordPress Trac noreply at wordpress.org
Fri Feb 10 23:24:56 UTC 2017


#39055: REST API: order is ignored when orderby is set to include
-------------------------------------------------+-------------------------
 Reporter:  joshlevinson                         |       Owner:  jnylen0
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  4.8
Component:  Query                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  refresh                                        |
-------------------------------------------------+-------------------------

Comment (by jnylen0):

 I think we are getting close here 😅

 However, these tests don't match the expected behavior discussed earlier
 in the ticket, and they also fail on my WP install.  It looks like you
 still have [attachment:39055.diff] from earlier in the thread applied to
 your WP checkout.

 > Are there any resources I might have missed for guidance on where to
 place tests, or is just a matter of figuring it out on a case by case
 basis?

 I'm not aware of any - I noticed on a closer look that everything in
 `search.php` was testing the `search` parameter, and `results.php`
 contained more generic tests.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39055#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list