[wp-trac] [WordPress Trac] #39055: REST API: order is ignored when orderby is set to include
WordPress Trac
noreply at wordpress.org
Thu Feb 9 06:59:42 UTC 2017
#39055: REST API: order is ignored when orderby is set to include
-------------------------------------------------+-------------------------
Reporter: joshlevinson | Owner: jnylen0
Type: enhancement | Status: accepted
Priority: normal | Milestone: 4.8
Component: Query | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests needs- | Focuses:
refresh |
-------------------------------------------------+-------------------------
Comment (by fibonaccina):
Thanks a lot for the feedback @jnylen0 !
It seems my IDE (PhpStorm) was adding some unexpected indentation. Your
link was very useful, I hadn't stumbled onto the WordPress-specific PHP
coding standards yet, this will be very helpful going forward. I believe
I've fixed the indentation, please let me know if anything doesn't look
right. The newest version is `39055_tests_current_behavior_refresh.diff`
As well, I wavered quite a bit whether to place the tests in
{{{search.php}}} or {{{results.php}}}. Admittedly in the end I made a more
or less educated guess, but especially now understanding the issue much
better, there isn't a doubt in my mind that {{{results.php}}} is the
correct place. Are there any resources I might have missed for guidance on
where to place tests, or is just a matter of figuring it out on a case by
case basis?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39055#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list