[wp-trac] [WordPress Trac] #41057: Update PHP codebase per WordPress PHP Coding Standards
WordPress Trac
noreply at wordpress.org
Wed Aug 30 16:59:04 UTC 2017
#41057: Update PHP codebase per WordPress PHP Coding Standards
----------------------------+-----------------------
Reporter: netweb | Owner: pento
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 4.9
Component: General | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
----------------------------+-----------------------
Comment (by jrf):
While preparing my talk for WC Nijmegen this weekend, I did another test
run with PHPCS `master` and WPCS `develop` - I'll attach the ruleset I
used as `phpcs6.xml.dist`.
This yielded 26 files which failed to fix due to fixer conflicts.
I have investigated the most persistent one - see https://github.com
/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1112 - and
pulled a fix in PHPCS upstream:
https://github.com/squizlabs/PHP_CodeSniffer/pull/1633
Re-running everything with the fix applied only leaves one last file with
a fixer conflict `src\wp-admin\theme-install.php`.
I think we need to start recruiting more people to help with reviewing the
patches ?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41057#comment:58>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list