[wp-trac] [WordPress Trac] #41057: Update PHP codebase per WordPress PHP Coding Standards

WordPress Trac noreply at wordpress.org
Fri Aug 4 01:22:27 UTC 2017


#41057: Update PHP codebase per WordPress PHP Coding Standards
----------------------------+-----------------------
 Reporter:  netweb          |       Owner:  pento
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  4.9
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+-----------------------

Comment (by netweb):

 Replying to [comment:54 GaryJ]:
 > Current status:
 >
 > - PHP CodeSniffer 3.0.2 was released 17 days ago.
 > - WordPress Coding Standards (which now has support for PHPCS 3.*)
 [https://github.com/WordPress-Coding-Standards/WordPress-Coding-
 Standards/releases/tag/0.13.0 0.13.0] was released about 11 hours ago.

 🎉

 > The latest patch here ([attachment:phpcs.xml.4.dist]) excludes a load of
 files because of [https://github.com/WordPress-Coding-Standards/WordPress-
 Coding-Standards/issues/1017 WPCS#1017], but this is now marked as closed.
 The duplicate of that ticket ([https://github.com/WordPress-Coding-
 Standards/WordPress-Coding-Standards/issues/1065 WPCS#1065]), also closed,
 says that it was fixed upstream in PHPCS 3.0.2. Can some or all of these
 file patterns now be removed from the proposed `phpcs.xml.dist`?

 I've removed those exclusions in [attachment:phpcs.xml.5.dist]

 > With that done, how close are the rest of the files in being patched?

 Another round of testing and review using [attachment:phpcs.xml.5.dist]
 would be up next

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41057#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list