[wp-trac] [WordPress Trac] #31071: media / post_mime_type related queries are very slow on larger sites

[WordPress Trac]

#31071: media / post_mime_type related queries are very slow on larger sites
-------------------------------------------------+-------------------------
 Reporter:  archon810                            |       Owner:  pento
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.7.4
Component:  Media                                |     Version:  4.1
 Severity:  normal                               |  Resolution:
 Keywords:  2nd-opinion has-patch needs-testing  |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------
Changes (by jnylen0):

 * keywords:  dev-feedback reporter-feedback 2nd-opinion has-patch => 2nd-
     opinion has-patch needs-testing
 * milestone:  Future Release => 4.7.4


Comment:

 To me, [attachment:31071.2.diff] is the obvious change to make here:  it
 preserves the default behavior while adding a way to customize it in any
 way desired.  It's based on [attachment:media.php.diff] from @sboisvert
 with a couple of changes:

 - Filters default to `null` so that they can be overridden either way (the
 filters can decide whether to show or hide the "create playlist" buttons).
 - Filters have documentation.

 If there is a consensus to always show the "create playlist" buttons, I'm
 not strongly oppposed, but it does make sense to me to avoid showing links
 to create audio/video playlists if we know they can't be used.

 The patch is written for version 4.7.5 - I think we can get the filters in
 by then.  If we do that, though, we should probably still leave this
 ticket open afterwards pending a more complete solution.

 I'm milestoning as 4.7.4 for now because there's no 4.7.5 milestone yet,
 whether this gets into 4.7.4 or not is up to @swissspidy.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31071#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform