[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers
WordPress Trac
noreply at wordpress.org
Fri Sep 30 23:51:23 UTC 2016
#38172: Enable Video Headers in Custom Headers
-----------------------------+------------------------------
Reporter: davidakennedy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Themes | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
-----------------------------+------------------------------
Comment (by azaozz):
Replying to [comment:10 celloexpressions]:
> I think the fundamental idea is that a higher-level feature like theme
support for video should leverage lower-level core functionality rather
than implementing things separately. If we want to add a way for
`wp_video_shortcode` to skip the MediaElement stuff, that would work, but
building the video tag here feels wrong and fragments the core APIs for
video.
I agree in principle, however not sure we can use `wp_video_shortcode()`
in this case. Problems are that it is a specific "high-level" function
only for use with a shortcode. It does several things at the same time. It
is intended to run in post_content, is intended to get arbitrary input
from the users (through the shortcode), adds MediaElement.js with specific
markup, etc. The first thing it does is to limit the video width to
`$content_width` which is wrong for a header :)
We can try to abstract some parts of it in "low level" functions, but not
sure what that will be like. At first look it seems there is not much that
can be used in the current patch here and can be abstracted.
Replying to [comment:9 davidakennedy]:
> I went at this thinking a simple starting point was to use the HTML5
`<video>` tag as is and just fallback to an image for anything that
doesn't support it. It seems reasonable, very future friendly and less
complex. The idea of easily skinning MediaElement.js is nice though. I do
think controls will be needed for accessibility reasons.
>
> Explaining video encoding to users is frightening to me. :) I'm
wondering if we can say it supports `.mp4` and that's it.
Not sure what's best here either. Using Flash for a video player seems
outdated. On the other hand that means we will be supporting only a
particular video format. Then should have nice help/explanations that only
one video format can be uploaded for use in the headers. That implies the
users will have to be able to convert videos they've shot, etc.
Agree that if we can get "skinless" MediaElement.js, we should try it.
However relying on YouTube or Vimeo seems bad as they can change the way
they handle requests at any time, and "break" every site that uses this.
The only possible integration with an external service seems to be with
VideoPress as we can make sure this use is supported there (but that is
probably a plugin material).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list