[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-----------------------------+------------------------------
 Reporter:  davidakennedy    |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Themes           |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+------------------------------

Comment (by bradyvercher):

 My understanding was that this feature was going to be limited to
 relatively short, looping background videos without controls -- a moving
 header image if you will -- which is why I felt MediaElement.js was
 overkill. Videos are hefty enough, so I think we should be optimizing the
 output as much as possible instead of further hurting performance on sites
 that use this feature.

 That being said, as long as themes are provided with the source files to
 generate their own markup, I'm not too concerned about the default
 implementation.

 Replying to [comment:9 davidakennedy]:

 > The idea of easily skinning MediaElement.js is nice though.

 I'm pretty sure the words "easily skinning MediaElement.js" don't belong
 together in the same sentence 😉

 Replying to [comment:10 celloexpressions]:

 > If we want to add a way for `wp_video_shortcode` to skip the
 MediaElement stuff, that would work, but building the video tag here feels
 wrong and fragments the core APIs for video.

 I guess we just disagree on what constitutes a core API -- calling a
 method with a "shortcode" suffix and shortcode-specific parameters when
 shortcodes aren't involved feels wrong from an API standpoint. I don't
 think it's a showstopper by any means, though. If it has to be used and
 MediaElement.js isn't going to be loaded, there is a filter that would
 allow for disabling it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform