[wp-trac] [WordPress Trac] #27314: Make sure button-primary has button class

WordPress Trac noreply at wordpress.org
Wed Sep 28 19:53:10 UTC 2016


#27314: Make sure button-primary has button class
-------------------------+---------------------------------
 Reporter:  iseulde      |       Owner:  chris_d2d
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  4.7
Component:  General      |     Version:  3.8
 Severity:  normal       |  Resolution:  fixed
 Keywords:  has-patch    |     Focuses:  ui, administration
-------------------------+---------------------------------
Changes (by afercia):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38672"]:
 {{{
 #!CommitTicketReference repository="" revision="38672"
 Administration: Improve the usage of the button CSS classes.

 Introduces some consistency in the usage of the button CSS classes, fixes
 the
 focus style for accessibility and responsiveness of the buttons.

 - Adds the `button` class to all primary buttons make them responsive
 - Removes all `secondary-button` classes and replaces it with button when
 needed. `button-secondary` shouldn't be used and exists just for backward
 compatibility reasons
 - Replaces classes inside `submit_button()` with a shorthand for some
 buttons, and use an empty string for the default `button` class. Passing
 `button` is unnecessary
 - Adjusts `get_submit_button()` to remove empty items

 Props iseulde, dimchik, chris_d2d, mhowell, afercia.
 Fixes #27314, #37138, #37448.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27314#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list