[wp-trac] [WordPress Trac] #27314: Make sure button-primary has button class

[WordPress Trac]

#27314: Make sure button-primary has button class
-------------------------+---------------------------------
 Reporter:  iseulde      |       Owner:  chris_d2d
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  4.7
Component:  General      |     Version:  3.8
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, administration
-------------------------+---------------------------------
Changes (by afercia):

 * keywords:  has-patch ui-feedback good-first-bug needs-testing => has-
               patch


Comment:

 Refreshed patch. Tried to address all the points mentioned in the ticket
 description and comments. Additionally, there's a mixed situation now
 where `submit_button()` is sometimes used passing an empty string for the
 CSS class, and sometimes passing `button` (alone or together with other
 classes). Since passing `button` is unnecessary, I'd propose to
 standardise and remove it. This implies a small adjustment to
 `get_submit_button()` in order to remove empty items to avoid a single
 class `button` being printed out with a space at the end `class="button
 "`.

 The patch is pretty big and would need to be merged as soon as possible :)
 Any feedback welcome, see also the QUnit tests part. /cc @helen @iseulde

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27314#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform