[wp-trac] [WordPress Trac] #37843: `http_api_curl` hook no longer available for adding custom cURL options

[WordPress Trac]

#37843: `http_api_curl` hook no longer available for adding custom cURL options
--------------------------+------------------
 Reporter:  ChaseWiseman  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.7
Component:  HTTP API      |     Version:  4.6
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |     Focuses:
--------------------------+------------------
Changes (by ocean90):

 * milestone:  Awaiting Review => 4.7


Comment:

 Another report: https://github.com/rmccue/Requests/issues/233.

 #33055 had a hook adapter `WP_Requests_Hooks` but it was removed before
 the final commit:

 [comment:ticket:33055:29 rmccue]:
 > […] removes the hook adapter. Hooks in Requests are scoped to a single
 request/session, and the internal plugins (Basic auth, proxying, etc) rely
 on this fact. Attaching the hooks to WP actions/filters breaks this.

 See also [37429].

 ----

 [attachment:37843.patch] allows to define your own hooks for custom
 requests. But this still doesn't allow to customize all requests per
 default. A filter like @JRGould has proposed makes probably more sense
 here.

 @dd32, @rmccue: What are your thoughts on this?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37843#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform