[wp-trac] [WordPress Trac] #32360: Add oEmbed provider unit tests

[WordPress Trac]

#32360: Add oEmbed provider unit tests
-------------------------+--------------------------
 Reporter:  johnbillion  |       Owner:  johnbillion
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  4.7
Component:  Embeds       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |     Focuses:
-------------------------+--------------------------

Comment (by johnbillion):

 So the reason these tests hadn't gone into core up until this point is
 because there are so many failures with the external providers.

 The tests are quite volatile too (I can see at least two tested URLs which
 are 404ing that previously weren't), for example Kickstarter is sending me
 `429 Too Many Requests` responses, and Cloudup is sending me `502 Bad
 Gateway` intermittently.

 I guess it makes sense for the tests to remain in a group which never gets
 tested by default (ie. without passing the `--group external-oembed`
 flag), but then I'm not sure if that's super valuable.

 In addition, the `testOembedProviderReturnsExpectedResponse()` test really
 needs to be split into several smaller tests so that every assertion can
 be performed (as opposed to the test failing at the first assertion
 failure). This means moving the actual HTTP requests into a data provider.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32360#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform