[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

WordPress Trac noreply at wordpress.org
Thu Oct 27 16:24:47 UTC 2016


#38172: Enable Video Headers in Custom Headers
-------------------------------------+-------------------------------------
 Reporter:  davidakennedy            |       Owner:  joemcgill
     Type:  task (blessed)           |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.7
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  ux-feedback dev-feedback has-      |  javascript
  screenshots                        |
-------------------------------------+-------------------------------------

Comment (by joemcgill):

 [attachment:38172.16.diff] proposes setting default minimum viewport
 height and widths in `get_header_video_settings()` and letting those
 values be filterable so themes can modify their minimum widths based on
 the layout of the theme. Not sure if this is the best idea in general, but
 seems there should be a way for themes to override whatever defaults we
 set.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:71>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list