[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-------------------------------------+-------------------------------------
 Reporter:  davidakennedy            |       Owner:  joemcgill
     Type:  task (blessed)           |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.7
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  ux-feedback dev-feedback has-      |  javascript
  screenshots                        |
-------------------------------------+-------------------------------------

Comment (by bradyvercher):

 [attachment:38172.12.diff] restores selective refresh and video looping.

 Twenty Seventeen still feels overly complicated, but it probably needs to
 do a few more things:
 * Set the `header_image` and `header_image_data` settings to use the
 `postMessage` transport
 * Toggle the `has-header-image` body class in `customizer.js` whenever any
 of the header settings are changed
 * Trigger whichever functions in `global.js` reposition the fixed
 navigation after a video is inserted

 Ideally, I would like to see a theme only have to call
 `the_custom_header()` without adding any logic to check to see if an image
 or video exists like Twenty Seventeen currently does.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:65>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform