[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-------------------------------------+-------------------------------------
 Reporter:  davidakennedy            |       Owner:  joemcgill
     Type:  task (blessed)           |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.7
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  ux-feedback dev-feedback has-      |  javascript
  screenshots                        |
-------------------------------------+-------------------------------------

Comment (by joemcgill):

 The conditional checks for loading the video, and the validation issues
 with external videos both look good in [attachment:38172.10.diff], but now
 previews are broken when you change the video.

 [attachment:38172.11.diff] fixes a couple of issues in Twenty Seventeen in
 [attachment:38172.10.diff], namely:

 1. The custom header CSS relies on the presence of a `.has-header-image`
 class which wasn't being added on front pages when a header video is set,
 but not a header video.
 2. This simplifies the logic of `template-parts/header/header-image.php`
 so custom headers aren't displayed on secondary pages if only a header
 video is set but no header image.

 Mentioned in Slack, but will mention again for posterity— video looping is
 working fine in Safari 9.1.2 (Mac) and IE9 & IE11 (Win) but not on FF or
 Chrome. It may be a quirk in how some browsers apply this functionality
 when partial content requests, see:
 http://stackoverflow.com/questions/8088364/html5-video-will-not-loop. We
 might need to fallback to an event listener that manually plays the video
 when it reaches the end.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:63>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform