[wp-trac] [WordPress Trac] #36901: Removing wp_die() from wp_allow_comment()

WordPress Trac noreply at wordpress.org
Wed Oct 12 04:24:45 UTC 2016


#36901: Removing wp_die() from wp_allow_comment()
-------------------------------------------------+-------------------------
 Reporter:  websupporter                         |       Owner:
     Type:  enhancement                          |  boonebgorges
 Priority:  normal                               |      Status:  reopened
Component:  Comments                             |   Milestone:  4.7
 Severity:  normal                               |     Version:  4.6
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests needs-dev-note                           |     Focuses:
-------------------------------------------------+-------------------------

Comment (by boonebgorges):

 [attachment:36901.10.diff] restores the previous status codes for comment
 floods and duplicates.

 For the record, the issue here is that wp-comments-post.php uses the
 `data` from the error object to send a status header:
 https://core.trac.wordpress.org/browser/tags/4.6.1/src/wp-comments-
 post.php?marks=24#L20 Previously, I overlooked this.

 Could I get a sanity check from @needle or anyone else who can reproduce?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36901#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list