[wp-trac] [WordPress Trac] #25239: $_SERVER['SERVER_NAME'] not a reliable when generating email host names
WordPress Trac
noreply at wordpress.org
Tue Oct 11 18:45:12 UTC 2016
#25239: $_SERVER['SERVER_NAME'] not a reliable when generating email host names
-------------------------------------------------+-------------------------
Reporter: layotte | Owner:
Type: defect (bug) | SergeyBiryukov
Priority: normal | Status: reviewing
Component: Mail | Milestone: Future
Severity: normal | Release
Keywords: has-patch dev-feedback needs- | Version: 3.8
testing | Resolution:
| Focuses:
-------------------------------------------------+-------------------------
Comment (by jdgrimes):
Replying to [comment:46 joemcgill]:
>I question whether this should be a pluggable function, though.
Yeah, I think that the consensus is that pluggable functions were a
mistake, and filter and action hooks should be used to provide
overridability/customizability. So no new pluggable functions are being
added, as far as I know.
So the function should be moved to a different file as you've suggested,
and we should consider the merits of adding a filter on the value that it
returns.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/25239#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list