[wp-trac] [WordPress Trac] #38657: Shrinkwrap npm dependencies for 4.7
WordPress Trac
noreply at wordpress.org
Fri Nov 25 05:56:13 UTC 2016
#38657: Shrinkwrap npm dependencies for 4.7
------------------------------+-----------------------
Reporter: netweb | Owner: nacin
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 4.7
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
------------------------------+-----------------------
Comment (by netweb):
Replying to [comment:9 nacin]:
> In the future, we need to be mindful that this thing needs to build on
Linux, and probably come up with a way to assert that without it first
being discovered when the build server fails. A cheap hack (for this
particular problem) that would have identified this quickly would be to
validate in unit tests that npm-shrinkwrap.json can't contain the string
'"fsevents"'.
Currently `npm-shrinkwrap.json` is never committed to `/trunk`, it only
exists in `/branch/x.y`, until it is created we can't test it, so on that
front @jorbin now that `/trunk` has branched can you add the 4.7 branch to
the [https://travis-ci.org/aaronjorbin/develop.wordpress/branches Travis
CI config] please and we can look to adding a test for this.
Also I hit upon [https://github.com/Skyscanner/grunt-custom-shrinkwrap
grunt-custom-shrinkwrap] and added in [attachment:38657-grunt-
shrinkwrap.diff] a new grunt task `grunt customShrinkwrap`, this creates
the `npm-shrinkwrap.json` file excluding the `fsevents` dependancy, the
`npm-shrinkwrap.json` file can then be moved manually into `/branch/x.y`
when `/trunk` is branched as part the new major release workflow.
This patch needs a bit more testing as it reports WordPress 4.8 currently
as the task is ran out of `/trunk` and `/trunk` has already branched. Also
the release workflow [https://make.wordpress.org/core/handbook/about
/release-cycle/releasing-major-versions/#post-release handbook docs]
should document this task if committed
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38657#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list