[wp-trac] [WordPress Trac] #38657: Shrinkwrap npm dependencies for 4.7

[WordPress Trac]

#38657: Shrinkwrap npm dependencies for 4.7
------------------------------+-----------------------
 Reporter:  netweb            |       Owner:  nacin
     Type:  task (blessed)    |      Status:  accepted
 Priority:  normal            |   Milestone:  4.7
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+-----------------------
Changes (by nacin):

 * owner:  jorbin => nacin
 * status:  reopened => accepted


Comment:

 Using node 6.9.1 (LTS) and npm 3.10.8, I was able to reproduce a
 shrinkwrap identical to [39358] on macOS and Linux, with the exception of
 fsevents being omitted on Linux. (In both scenarios, I also see an
 irrelevant change to the metadata for the "nan" package.)

 When using that Linux-generated shrinkwrap on macOS, node-gyp ends up
 installing fsevents properly, so it's not needed in npm-shrinkwrap.json.

 So, I have a good fix for this, but need to update node and npm on the
 build server, which I'll do soon.

 In the future, we need to be mindful that this thing needs to build on
 Linux, and probably come up with a way to assert that without it first
 being discovered when the build server fails. A cheap hack (for this
 particular problem) that would have identified this quickly would be to
 validate in unit tests that npm-shrinkwrap.json can't contain the string
 '"fsevents"'.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38657#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform