[wp-trac] [WordPress Trac] #38832: WP_Image_Editor can no longer edit PDF pages other than the first one

WordPress Trac noreply at wordpress.org
Fri Nov 18 02:08:05 UTC 2016


#38832: WP_Image_Editor can no longer edit PDF pages other than the first one
-----------------------------------+---------------------------
 Reporter:  mikeschroder           |       Owner:  mikeschroder
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.7
Component:  Media                  |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------------

Comment (by joemcgill):

 Thanks Mike. Those echo my main concerns with this approach as well, but
 was looking for a way to do this that:

 a) Didn't introduce a new filterable value into the logic chain, and
 b) Left PDF implementation details out of the `load()` method to ensure
 backcompat with anything extending the `WP_Image_Editor_Imagick` class.

 The only other way I could see us getting around this is to put an action
 hook or filter between the instantiation of the Imagick object on
 `$this->image` and the `$this->image->readImage()` call.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38832#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list