[wp-trac] [WordPress Trac] #38832: WP_Image_Editor can no longer edit PDF pages other than the first one

WordPress Trac noreply at wordpress.org
Fri Nov 18 00:41:21 UTC 2016


#38832: WP_Image_Editor can no longer edit PDF pages other than the first one
-----------------------------------+---------------------------
 Reporter:  mikeschroder           |       Owner:  mikeschroder
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.7
Component:  Media                  |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------------

Comment (by mikeschroder):

 Hmm. Took a look; thanks for putting it together! Interesting workaround
 -- hadn’t thought about running _choose separately.

 Two (related) notes:
 - If we can, I’d prefer to avoid adding additional public methods on only
 one type of `WP_Image_Editor`, since it could lead to more third party
 code that will only work with the Imagick editor (but would fail if
 another editor is selected).
 - I’m not a huge fan of `update_file` being public, since the
 `WP_Image_Editor` model is supposed to surround a single input file, and
 this would not have the effect expected by developers if run from outside
 of a `WP_Image_Editor`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38832#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list