[wp-trac] [WordPress Trac] #38818: REST API: Support ipv6 for `author_ip` in comments endpoint

WordPress Trac noreply at wordpress.org
Wed Nov 16 15:28:45 UTC 2016


#38818: REST API: Support ipv6 for `author_ip` in comments endpoint
-------------------------------------------------+-------------------------
 Reporter:  dd32                                 |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.7
Component:  Comments                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  rest-api
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by schlessera):

 Replying to [comment:2 joehoyle]:
 > I'd get rid of `rest_is_ipv4_address` and `rest_is_ipv6_address` and
 just have a single function that can validate either. Same for the schema
 types.

 I agree that all code should ideally support both. However, getting rid of
 the schema type `ipv4` in favor of `ip` might break existing code that
 already relies on the schema type `ipv4`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38818#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list