[wp-trac] [WordPress Trac] #38818: REST API: Support ipv6 for `author_ip` in comments endpoint

WordPress Trac noreply at wordpress.org
Wed Nov 16 15:23:12 UTC 2016


#38818: REST API: Support ipv6 for `author_ip` in comments endpoint
-------------------------------------------------+-------------------------
 Reporter:  dd32                                 |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.7
Component:  Comments                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  rest-api
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by joehoyle):

 I think we should stick with just `rest_is_ip_address`, I don't see a need
 to validation `ipv4 / ipv6` separately, doing so will only make it more
 likely they developers only support one of the formats, when really all
 code should be written to support both. I'd get rid of
 `rest_is_ipv4_address` and `rest_is_ipv6_address` and just have a single
 function that can validate either. Same for the schema types.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38818#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list