[wp-trac] [WordPress Trac] #38651: Customizer edit icons may be partially off-screen in Device Preview mode

WordPress Trac noreply at wordpress.org
Tue Nov 15 00:04:03 UTC 2016


#38651: Customizer edit icons may be partially off-screen in Device Preview mode
---------------------------------------+--------------------------
 Reporter:  afercia                    |       Owner:  westonruter
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  4.7
Component:  Customize                  |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+--------------------------
Changes (by westonruter):

 * owner:  davidakennedy => westonruter
 * status:  reviewing => accepted


Comment:

 In [attachment:38651.9.diff] I realized that the underlying `customize-
 preview.css` was adding style properties to the `site-title`
 unnecessarily. Namely, the styles should only be added if the edit
 shortcuts are shown. And we can know this by adding `body.customize-
 partial-edit-shortcuts-shown` to the selectors. This should ensure that
 when the customizer controls are collapsed, the page layout should appear
 as it will on the frontend, and the adjustments to the layout will only be
 done when there needs to be room made for the edit shortcuts.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38651#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list