[wp-trac] [WordPress Trac] #38391: Twenty Seventeen: Background colour for header

[WordPress Trac]

#38391: Twenty Seventeen: Background colour for header
--------------------------------------+----------------------------
 Reporter:  laurelfulford             |       Owner:  davidakennedy
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.7
Component:  Bundled Theme             |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+----------------------------

Comment (by davidakennedy):

 In testing, it looks like the patch in #38627
 (https://core.trac.wordpress.org/attachment/ticket/38627/38627.3.diff)
 also solves this issue. I'll get it committed soon, but I'd also recommend
 not setting a default text color.

 This means, if a user clicks default text color in the Customizer – no
 matter which header style they have, it falls back to the CSS in
 `style.css`. The preview changes with the header media changes… if they
 have used a default text color, it works everywhere and if they switch
 back to the default (blank) from a custom color, it uses the theme’s CSS,
 and the preview matches.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38391#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform