[wp-trac] [WordPress Trac] #38391: Twenty Seventeen: Background colour for header

[WordPress Trac]

#38391: Twenty Seventeen: Background colour for header
--------------------------------------+----------------------------
 Reporter:  laurelfulford             |       Owner:  davidakennedy
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.7
Component:  Bundled Theme             |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+----------------------------

Comment (by davidakennedy):

 Replying to [comment:11 helen]:
 > I've been a little confused about this ticket and various terminology
 being thrown around, so to try to be sure I'm understanding, here's what
 I've got:
 >
 > * When there is a header image or video, the header text defaults to
 white.

 Yes.

 > * When there is not, the header text defaults to black in the light
 color scheme, white in the dark color scheme, and ??? in custom.

 Yes.

 > * When removing a header image or video, the header area does not
 collapse (#38627) and the header text remains white even if the current
 color scheme is light with the header text color as default (the bug being
 described in this ticket).

 Yes.

 > * Bug: the header text color control does not change to reflect the
 current default color based on scheme.

 Yes. And it doesn't change to suit the `style.css`. A theme can change the
 header (site title and tagline) text color in the CSS to accommodate
 visual changes, like Twenty Seventeen does with or without a image/video
 background in the header. But there is always one default text color,
 which may not always match up to what the user sees.

 > * The color scheme and header text color controls should always be
 shown.

 Probably, yes. Although one idea here was to only show the controls if a
 user had a image or video in the background.

 This issue in this ticket could have been more clearly explained, and it's
 tough because there are a few things. So thanks for diving in and getting
 to the problems succinctly. :) It comes down to the preview not matching
 the front end at times. And we haven't hit on a good solution for that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38391#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform